Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: basesrc/usr.bin/make



In article <20011102035222.C65C9B008%cvs.netbsd.org@localhost>,
Todd Vierling <tv%netbsd.org@localhost> wrote:
>
>Module Name:   basesrc
>Committed By:  tv
>Date:          Fri Nov  2 03:52:22 UTC 2001
>
>Modified Files:
>       basesrc/usr.bin/make: main.c
>
>Log Message:
>Strike getenv("PWD") entirely, based on prior discussion with sjg.  This
>breaks too many situations, including MAKEOBJDIR with a :C,foo,bar,
>transform in many cases.  It's ambiguous and unreliable, as the comment
>above that code always indicated.  In order to have reliable objdirs, they
>need to work the same way Every Time.
>
>(Note that taking this out is not a performance hit; we were already doing
>the getcwd() call first.  So the getenv("PWD") didn't increase performance.)
>

You know this breaks a lot of things specially in the presence of automounted
filesystems...

christos



Home | Main Index | Thread Index | Old Index