Re: CVS commit: basesrc/bin/pax

[christos%zoulas.com@localhost (Christos Zoulas)]

On Feb 1,  8:35am, tv%wasabisystems.com@localhost (Todd Vierling) wrote:
-- Subject: Re: CVS commit: basesrc/bin/pax

| On 1 Feb 2002, Perry E. Metzger wrote:
| 
| : > Of course, if KNF didn't specify direct inclusion of <sys/cdefs.h> at the
| : > very top of the file (which it shouldn't, braindead bull$%^t), I wouldn't
| : > have to fight this bogosity.
| :
| : Maybe we should define an #include file that only does _RCSID and
| : _COPYRIGHT?
| 
| What I was trying to say is that if the __RCSID and __COPYRIGHT macros
| lived *below* the include list rather than above it, the inclusion of
| "config.h" could easily redefine these, and we wouldn't even need to
| explicitly include <sys/cdefs> at all.  We don't need another .h file.
| 
| However, our style currently mandates that the file be structured as:
| 
| #include <sys/cdefs.h>
| __RCSID()
| #include <everything_else>

Probably it would be best to change the style to do as you suggest. Since
we're going to have to go through each individual source file for every
host tool and fix it.

christos