Re: CVS commit: basesrc/bin/sh

[enami tsugutomo <enami%sm.sony.co.jp@localhost>]

christos%zoulas.com@localhost (Christos Zoulas) writes:

> | >                   varnest++;
> | > +                 if (varnest >= maxnest) {
> | > +                         maxnest += 32;
> | > +                         dblquotep = ckrealloc(dblquotep, maxnest / 8);
> | > +                         if (maxnest == 64)
> | > +                                 *dblquotep = dblquote;
> | 
> | ...here, dblquotep[0] is initialized with dblquote.  It looks
> | inconsistient.
> 
> Yes, but I wanted to keep the dblquotep array correct no matter if it is used
> or not. It is a good programming practice to keep data consistent.

Once the varnest become < 32 again, data will be inconsistient.

enami.