Re: CVS commit: basesrc/sbin/newfs

[Luke Mewburn <lukem%netbsd.org@localhost>]

On Sat, Feb 16, 2002 at 09:39:30PM +0200, Jason R Thorpe wrote:
  | Modified Files:
  |     basesrc/sbin/newfs: newfs.c
  | 
  | Log Message:
  | * Undo rev 1.55.  While one might think this test is useful, newfs
  |   has historically allowed file systems to be created on non-4.2BSD
  |   partitions, and the ability to do so is quite useful to some people.

I'm curious as to who finds the old behaviour so useful and/or
necessary that they can't first edit the disklabel to contain the
correct partition type and other information, or use newfs -F
(which ignores the disk label entry entirely).

I received a reasonable amount of positive feedback about the addition
of that test (which prevents non 4.2BSD file systems from being newfs-ed
unless you use -F), and having been bitten myself by accidentally
newfs-ing the wrong partition because of a one character typo (and I'm
sure that I'm not the only one), I disagree strongly with your backing
out of that test.


  | To generate a diff of this commit:
  | cvs rdiff -r1.56 -r1.57 basesrc/sbin/newfs/newfs.c
  | 
  | Please note that diffs are not public domain; they are subject to the
  | copyright notices on the relevant files.


Luke.