Re: CVS commit: basesrc

[Jason R Thorpe <thorpej%wasabisystems.com@localhost>]

On Wed, Jun 19, 2002 at 03:17:11AM +0300, Luke Mewburn wrote:

 > Module Name: basesrc
 > Committed By:        lukem
 > Date:                Wed Jun 19 00:17:11 UTC 2002
 > 
 > Modified Files:
 >      basesrc: Makefile
 > 
 > Log Message:
 > In afterinstall, only run postinstall check if DESTDIR != / (or equivalents).
 > Fixes [misc/17275] from Gregory McGarry <g.mcgarry%ieee.org@localhost>

This change is incorrect (yes, I know the commit message has a typo).

Consider the case of building into an already populated NFS root
for a diskless client (this is something I do quite regularly).
I would now have to run the postinstall-check phase manually, which
means extra work.

Needless to say, I'm not too pleased about it (I already have enough
to do).

Instead, I think that you should skip the postinstall-check in
afterinstall: only if the target originally invoked at the top-level
was "distribution" or "release".  You can safely assume that the
DESTDIR is empty (or at least known to be invalid) in that case, and
this preserves the previous (and quite useful) behavior for the case
I mentioned above.

-- 
        -- Jason R. Thorpe <thorpej%wasabisystems.com@localhost>