Re: CVS commit: src/sbin/newfs

[Bill Studenmund <wrstuden%netbsd.org@localhost>]

On Thu, 4 Sep 2003, David Laight wrote:

> > >   src/sbin/newfs: mkfs.c
> > >
> > > Log Message:
> > > Randomise di_igen for the first 2 blocks of inodes for non-UFS2 
> > > filesystems.
> > > Randomise di_igen for "/" (and lost+found) for UFS2 filesystems.
> > > Ensure nothing from the lost+found inode leaks into the / inode.
> >
> > Uhm, where was this discussed? You've taken the combination of a
> > deterministic process + tool (fsirand) and forced them together with no
> > options. While it may be time to have inode # randomization the default,
> > it should: 1) be discussed, and 2) be controlable.
>
> Actually I didn't, I just fixed the existing code so that it actually did
> what it was trying to do!
>
> This all came in with the UFS2 support, however it was using cg_initediblk

Ok, so I should blame someone else.

While you're working on this, could you add an option to control this?
Either the option causes the randomization, or disables it. I'd prefer
enables it (not default), but if everyone screams for it, having it the
default will be tollerable.

> to determine how many of the inodes to initialise (ie randomise di_gen
> and zero) - which got zeroed for UFS1.  The rest of the inodes only get
> initialised for UFS1 and were being given a random di_gen.
> This fixed showed that when the directory inodes are written they (again)
> picked up a zero di_gen.

?? Oh, we now once again give di_gen of zero? I'm confused.

Take care,

Bill