Re: CVS commit: src/crypto/dist/ssh

[David Young <dyoung%pobox.com@localhost>]

On Tue, Sep 16, 2003 at 01:22:59PM +0000, Christos Zoulas wrote:
> 
> Module Name:  src
> Committed By: christos
> Date:         Tue Sep 16 13:22:58 UTC 2003
> 
> Modified Files:
>       src/crypto/dist/ssh: buffer.c
> 
> Log Message:
> Do not record expanded size before attempting to reallocate the associated
> memory. From OpenBSD, via FreeBSD.

Just in case this patch made anybody else scratch their head, the bug it
fixes seems to be that when xrealloc() fails in buffer_append_space(), it
calls fatal()->fatal_cleanup()->function pointer->buffer_free()->memset(),
which zeroes 32K bytes too many because the expanded size is already
recorded.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933