Re: CVS commit: src/sys/dev/ic

[David Young <dyoung%pobox.com@localhost>]

On Tue, Sep 30, 2003 at 06:19:09AM +0200, Quentin Garnier wrote:
> Le Mon, 29 Sep 2003 18:30:51 -0500
> David Young a ecrit :
> > On Sun, Sep 28, 2003 at 10:24:09PM +0000, Quentin Garnier wrote:
> [...]
> > > Log Message:
> > > Change the way of setting a port value so that a change too small to
> > > fit in the number of bits used for the port still does something.
> > > 
> > > This fixes PR pkg/18741 for ac97-based hardware. Other audio drivers
> > > might need a similar fix.
> [...]
> > I do not think that the kernel should second-guess the application this
> > way. I think that most apps are (or will be) written with the
> > expectation that the mixer settings are stateless. I.e., if I write
> > volume=1 when the volume=0, then it should produce the same volume as
> > when volume=1 and I write volume=1, namely volume=1.
> 
> But volume will never be at 1. The application will never read such value
> from the mixer, if the delta is not 1.

16, then, if the delta is 16. =) My concern about a stateful volume
setting still stands.

> I'm ready to back this out, I'm not sure I'm ready to fix mp3blaster,
> mplayer and all the other loosily programmed mixers.

I think that backing it out and fixing mp3blaster, etc., is the right thing.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933