Re: CVS commit: src/gnu/dist/cvs/src

[christos%zoulas.com@localhost (Christos Zoulas)]

On Oct 5,  2:53am, jhawk%mit.edu@localhost (John Hawkinson) wrote:
-- Subject: Re: CVS commit: src/gnu/dist/cvs/src

| This is not the most descriptive log message. It should be better, I
| think. What are these patches intended to do, and how do they work?
| Clearly they effect setuid behavior.

It is pretty simple to understand what it is doing. Do you see anywhere
else in the cvs code documentation on how the setgid feature works?
Anyway since you ask apart from doing the same with setuid like the
setgid code does, it passes a flag so that cvs's executed children
relinguish their setuidness.

| Also, rev 1.11 of server.c has:
| 
| @@ -772,8 +772,7 @@
|         nothing.  But for rsh, we need to do it now.  */
|      parse_config (current_parsed_root->directory);
|  
| -    if (!nolock)
| -    {
| +    if (!nolock) {
|      path = xmalloc (strlen (current_parsed_root->directory)
|                    + sizeof (CVSROOTADM)
|                    + 2);
| 
| That sort of thing shoulodn't be happening, right?

Yes, it should because that eliminates an unneeded diff from the pkgsrc
source.

| Perhaps it (that hunk) should be reverted to simply future
| merging.

That is what the patch intends to do.

christos