Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sbin/newfs



On Friday, 10 October 2003 at  9:45:37 +0100, David Laight wrote:
>>>    The -V flag tells newfs not to make assumptions about the device name.
>>>
>>> i think the best thing would be to teach newfs to just try the name
>>> as-is first (perhaps the -F flag already does what you need, but i
>>> think it would be better for this to "just work.")
>>
>> Hmm, yes, this might be a good alternative.  I don't like having to
>> specify the size; possibly I can fix that, though.  I'll take a look.
>
> Maybe an ioctl that returns the disklabel info for the opened
> partition?

Like DIOCGDINFO?  Yes, Vinum implements that, but it's a kludge.

> newfs could use that instead of getting the volumes disklabel.

Well, I think it needs the volume's disk label, not the partition's
disk label.  The problem is that the concept of a disk label is
meaningless for a Vinum volume.

> OTOH what does vimun report if asked for a disklabel?

From the man page:

     In general, disklabel(8) serves no useful purpose on a vinum volume.  If
     you run it, it will show you three partitions, a, b and c, all the same
     except for the fstype, for example:

     3 partitions:
     #        size   offset    fstype   [fsize bsize bps/cpg]
       a:     2048        0    4.2BSD     1024  8192     0   # (Cyl.    0 - 0)
       b:     2048        0      swap                        # (Cyl.    0 - 0)
       c:     2048        0    unused        0     0         # (Cyl.    0 - 0)

     vinum ignores the DIOCWDINFO and DIOCSDINFO ioctls, since there is noth-
     ing to change.  As a result, any attempt to modify the disk label will be
     silently ignored.

> Maybe all its names should end in 'a'?

Heh.  That's a workaround at the best.

I think an improvement on the -F flag might be the way to go.  It
appears to want to do the same thing, and the only issue is that it
wants a size specification, which I think would normally not be
necessary.

Greg
--
See complete headers for address and phone numbers.

Attachment: pgpSAHtPlE_ik.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index