Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/whois



> 1) Commit log entries should contain a concise description of the change
>    that was made; you've been reminded of this previously.  

Yes I know (thanks for reminding me) but in this case, I wasn't
sure of all the points that were being addressed, long story
short, the patch (from the PR) did not solve anything and 
Christos felt we needed a better whois overall, 
in retrospect, I could have just put that in (for some 
reason, at the time, I thoughtI implied that in the message).

FWIW, I should have asked Christos for a list of points as to
why we needed to replace it (the only one I can remember is
recursion) so I could have put those in the message.

> 2) This looks like a candidate for a vendor-branch import.

That is a good point too, at the time I was told to just
commit as is.

Would you like me to cvs admin the message so the history for
the file is a little more sensible?

Thanks.
        j




Home | Main Index | Thread Index | Old Index