Re: CVS commit: src

[James Chacon <jmc%NetBSD.org@localhost>]

On Tue, Oct 28, 2003 at 01:56:25PM +0300, Valeriy E. Ushakov wrote:
> On Tue, Oct 28, 2003 at 16:50:21 +1100, Luke Mewburn wrote:
> 
> > On Mon, Oct 27, 2003 at 11:14:08PM -0600, James Chacon wrote:
> >   | We provide that in nbcompat? The specific thing I was fixing here
> >   | was tools/ lossage from hosting on non-NetBSD for cross building.
> > 
> > Yes, we do;  look at tools/compat/compat_defs.h.
> > usr.sbin/installboot uses these macros and it cross builds fine.
> 
> I think the config test for sys/endian.h is too coarse.  I.e. a host
> that have sys/endian.h, but the one which doesn't provide all the
> atob* functions that ours does (e.g. FreeBSD) - will have build
> problems.
>

I'll also note my change was a 1 line change that works basically everywhere.
Converting to use a NetBSD specific extension + compat is a lot more
prone to error (and I couldn't test nearly as easily on a wide variety
of hosts).

James