On Fri, Nov 07, 2003 at 12:19:18PM +0100, Jaromir Dolecek wrote: > Bill Studenmund wrote: > > You changed field names and deleted one. You really should bump the > > version. The point isn't just that you kept struct proc's layout the same, > > it's that you renamed something. > > > > While you've done an excelent job of maintaining binary compatability, you > > have broken source compatability. The packages I'm familiar with that try > > to keep lkms and drivers up to date use defines based on kernel version. > > This change makes it so that that behavior (defines) doesn't work. > > This change doesn't affect LKMs in any way. These fields were > private kernel only, only used by the actual RAS code. Are you sure? You are talking about the RAS code, but David changed more than that. He changed the name of the lock on all of struct proc. That is used outside of just the RAS code. Take care, Bill
Attachment:
pgps_EeSv6KlK.pgp
Description: PGP signature