Re: CVS commit: src/sys/sys

[Luke Mewburn <lukem%NetBSD.org@localhost>]

On Fri, Nov 14, 2003 at 11:32:54AM +0000, David Laight wrote:
  | On Fri, Nov 14, 2003 at 08:15:31PM +0900, Izumi Tsutsui wrote:
  | > In article <20031114090633.J4919%snowdrop.l8s.co.uk@localhost>
  | > david%l8s.co.uk@localhost wrote:
  | > 
  | > > Because the code needs to look at the netbsd disklabel - which is 
defined
  | > > (apart from its size) in sys/disklabel.h.
  | > 
  | > But refering MAXPARTITIONS is completely wrong way to fix the problem.
  | > Probably Making symlinks to machine/disklabel.h under
  | > src/tools/compat/obj.*/include/ dir for building host tool
  | > is right way.
  | 
  | No - the alternative is to check for _MACHINE_DISKLABEL_H
  | You may (as in this case) have included the correct <arch>/disklabel.h.
  | 
  | sys/disklabel could be in src/tools/compat/sys - but you still need to
  | stop in going after machine/* since you don't know 'machine'.
  | 
  | I used MAXPARTITIONS because that is the value that sys/disklabel.h
  | needs from machine/disklabel.h


I've backed out the change and disabled hp300 support in installboot
(the second time core has had to do the latter),

Do not reenable it again until you have discussed it with core and it
meets our satisfaction.

Thank you,
Luke.