Re: CVS commit: src/sys/arch/sgimips/sgimips

[Christopher SEKIYA <wileyc%rezrov.net@localhost>]

On Mon, Jan 12, 2004 at 10:35:11PM +1100, Simon Burge wrote:

> I haven't looked in detail at the code in question, but if a "* 8" is clearer
> than a "<< 3" then I'd be tempted to leave it as is...

Maybe it's a style thing -- I was taught that bit shifts were preferred to
multiplication/division, and IMHO when dealing with bits in registers, it's
easier to read "<<" rather than "*".

I'll gladly change the two instances back, though, if popular opinion is against
me :)

-- Chris
        GPG key FEB9DE7F (91AF 4534 4529 4BCC 31A5  938E 023E EEFB FEB9 DE7F)