Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/lib/libc



Module Name:    src
Committed By:   drochner
Date:           Mon May 10 16:47:11 UTC 2004

Modified Files:
        src/lib/libc/include: namespace.h
        src/lib/libc/stdio: fgetln.c fgetstr.c local.h

Log Message:
After discussion with christos, turn fgetstr() into an internal function.
Its API in inherently non-threadsafe (and it depends on certain properties
of the underlying stdio implementation), so it shouldn't be a first-class
function for general use, polluting the application namespace.
Also remove the FLOCKFILE() code from it - this is under control of the
calling function now.
(XXX I'm not sure whether the FLOCKFILE() should be kept in fgetln(),
this function cannot be used in multiple threads anyway. It doesn't
hurt much, and it might prevent corruption of internal FILE structures.)


To generate a diff of this commit:
cvs rdiff -r1.88 -r1.89 src/lib/libc/include/namespace.h
cvs rdiff -r1.13 -r1.14 src/lib/libc/stdio/fgetln.c
cvs rdiff -r1.1 -r1.2 src/lib/libc/stdio/fgetstr.c
cvs rdiff -r1.17 -r1.18 src/lib/libc/stdio/local.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index