Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/netkey



> > > - still leaks mbufs in the cases of ENOBUF?
> > 
> >     no, we loss "m" due to pullup.
> 
> m will be lost, but m->m_nextpkt isn't.

it seems that you already fixed it.  sorry for noise.

however, with keysock.c rev.1.34,
kp_queue will be stamped in the case of !canwait && ENOBUFS.
i think that it's better to always consult kp_queue first.
(ie. "if (canwait)" -> "if (1)".)

YAMAMOTO Takashi



Home | Main Index | Thread Index | Old Index