Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/miscfs



On Mon, Jun 07, 2004 at 05:36:38PM +0000, YAMAMOTO Takashi wrote:
> 
> Module Name:  src
> Committed By: yamt
> Date:         Mon Jun  7 17:36:38 UTC 2004
> 
> Modified Files:
>       src/sys/miscfs/genfs: layer_extern.h layer_vnops.c
>       src/sys/miscfs/nullfs: null_vnops.c
>       src/sys/miscfs/overlay: overlay_vnops.c
>       src/sys/miscfs/umapfs: umap_vnops.c
> 
> Log Message:
> do a LAYERFS_REMOVED hack for vop_rename as well.

I don't think the following test is needed:

              if (tvp->v_mount != fdvp->v_mount)
                      tvp = NULL;
              else
                      vref(tvp);

as VOP_RENAME() is not intended to support cross-mount renames; any call 
that ever did that would be an error.

My only concern with leaving the test in is that it might imply to some 
future programmers that they need to worry about a cross-mount rename.

Take care,

Bill

Attachment: pgpsTyLcO9c8R.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index