On Sun, Jun 20, 2004 at 02:15:24PM +0900, YAMAMOTO Takashi wrote: > > Actually I think it is about time we rip out the shadow locking that > > layered file systems are doing. When it was added, a number of file > > systems (nfs, kernfs, procfs) didn't do real node locking; they used > > genfs_nolock(). Now there are very few uses of genfs_nolock(), so I think > > we can just remove it. > > what's the "shadow locking" do you mean? LAYERFS_UPPERLOCK(), LAYERFS_UPPERUNLOCK(), and LAYERFS_UPPERISLOCKED(). They were for when NFS and other fs's didn't do real locking. Now, the only real fs that doesn't export a struct lock is union, and it does real locking on its own. So I don't think these are needed. Take care, Bill
Attachment:
pgp1g009f6GsA.pgp
Description: PGP signature