Re: CVS commit: xsrc/xfree/xc/programs/Xserver/hw/xfree86/drivers/ati

[manu%netbsd.org@localhost (Emmanuel Dreyfus)]

matthew green <mrg%eterna.com.au@localhost> wrote:

>    Does the change break on other Apple laptops? 
> do you not know that already?  ie, i'd hope you had wider testing of
> both new & old (ie, already working) hardware before commiting tis.

This is a question...

> yeah i'd like it to be an XF86Config option that you have to set, or
> at least derived someway and only enabled where it is known needed,
> or something.
> 
> i don't particularly understand the problem itself - i'm objecting
> to it being applied with a hammer to all powerpc platforms when it's
> (a) a complete hack (please clean up the magic number at least) and
> (b) it's already working in older systems...

Then what about the second solution I proposed: An ibookradeon driver.
ibookradeon_driver.c will just do that:

#define IBOOK
#include "radeon_driver.c"

And we'll ifdef IBOOK the changes in radeon_driver.c

-- 
Emmanuel Dreyfus
Il y a 10 sortes de personnes dans le monde: ceux qui comprennent 
le binaire et ceux qui ne le comprennent pas.
manu%netbsd.org@localhost