Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



In article <200408131212.18695.abuse%spamalicious.com@localhost>
abuse%spamalicious.com@localhost wrote:

> > Of course it's better to switch every port to bus_space(9),
> > but in current code register offsets are hidden by sci_xxx members
> > so it looks a bit strange to use offset C400_CSR directly in MI code.
> > I think such MD reset function should be set in MD attachment
> > and called by a function pointer in softc like sc->sc_intr_on() etc.
> 
> There is *absolutely* nothing machine-dependent about that particular 
> fiddling.

Hmm, not machine-dependent but 53c400 dependent?
If MI ncr5380sbc supports 53c400 quirk too, struct ncr5380_softc
should also have some members for c400 specific registers, I think.

Anyway, I'll switch news68k si(4) to NCR5380_USE_BUS_SPACE
but no idea about other ports.
---
Izumi Tsutsui
tsutsui%ceres.dti.ne.jp@localhost



Home | Main Index | Thread Index | Old Index