Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys/dev/ic



Module Name:    src
Committed By:   christos
Date:           Sun Oct 24 00:35:08 UTC 2004

Modified Files:
        src/sys/dev/ic: tulipvar.h

Log Message:
Change the sc_name buffer size from 16 to 32, since we already oveflow 16
in if_tlp_pci.c... The name code really needs to be fixed so that it does
not have a buffer overflow again:

1. the cardbus and eisa code don't initialize sc_name; it probably should?
2. tlp_attach() seems to print the name and the ethernet address, but
   the pci front end seems to do the same.
3. some of the name determination code in the pci front-end does not guarantee
   nul terminated strings.

Really, all this name code is just bloat and another place for bugs to hide.


To generate a diff of this commit:
cvs rdiff -r1.50 -r1.51 src/sys/dev/ic/tulipvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index