Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/macppc



On Sun, Nov 07, 2004 at 04:24:34AM +0000, Michael Wolfson wrote:
> 
> Module Name:  src
> Committed By: mbw
> Date:         Sun Nov  7 04:24:34 UTC 2004
> 
> Modified Files:
>       src/sys/arch/macppc/include: disklabel.h
>       src/sys/arch/macppc/macppc: disksubr.c
> 
> Log Message:
> Add disklabel recognition for  another Apple file type
> "BZB_ROOTFS_NEW        0xc000"

That value needs to be reverted. You've broken disklabel handling - what 
used to be a "usr" partition will now be a "root" partition.

BZB_ROOTFS_NEW is the OR of BZB_ROOTFS and BZB_USRFS, thus it can't 
possibly work right given the logic in disksubr.c. Also, anything that 
actually had a flag value of "BZB_ROOTFS_NEW" would have passed the 
previous test.

Please revert these changes.

Take care,

Bill

Attachment: pgpm2PJreaLd1.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index