Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/net



Hiya Matthew,

On Thu, Dec 30, 2004 at 11:38:57PM +1100, matthew green wrote:
> this change seems broken to me.  the #if you removed encompasses
> exactly how the label is used, and as you say, it now will fail
> without options INET.  what is the purpose of this change?  i
> think it should be reverted.

The change is :

@@ -732,9 +732,7 @@
        default:
                /* printf("token_input: unknown dsap 0x%x\n", l->llc_dsap); */
                ifp->if_noproto++;
-#if defined(INET) || defined(NS) || defined(DECNET)
        dropanyway:
-#endif
                m_freem(m);
                return;
        }
-----

In the same function (on line 790) there is the `catch-all' line that jumps 
to that label; if INET is not defined the label won't be defined without 
the patch!

                default:
                        /*
                        printf("token_input: unknown protocol 0x%x\n", etype);
                        */
                        ifp->if_noproto++;
                        goto dropanyway;
                }


Hope this helps...

Cheers,
Reinoud

Attachment: pgplN1DF_r_XH.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index