Re: CVS commit: src/share/mk

[Havard Eidnes <he%NetBSD.org@localhost>]

>   | Module Name:      src
>   | Committed By:     he
>   | Date:             Tue Jan 11 16:20:49 UTC 2005
>   |
>   | Modified Files:
>   |   src/share/mk: bsd.own.mk
>   |
>   | Log Message:
>   | Add a default setting of MKPAM to "yes".
>   |
>   | To generate a diff of this commit:
>   | cvs rdiff -r1.431 -r1.432 src/share/mk/bsd.own.mk
>
> This makes rev 1.431 obsolete without removing the code for 1.431.

Yes, I've been made aware of that after I committed it; I had fallen
behind on my source-changes reading.  It is not my intention to start
a commit war.

> I am not sure that MKPAM should be set to "yes" at this time, given
> that <manu> set MKPAM=no after discussion with a few of us, at least
> until we knew that the PAM integration was stable enough to use.

Well, before my change introducing MKPAM the default was to build
libpam, I just preserved that for the ports which could build libpam.
I should perhaps have investigated more closely why the default was
changed.

At the moment MKPAM only regulates whether the library will be built
or not, and it appeared at least to my eyes that the library itself
was sort of stable, and it also built nicely on most ports, so my gut
reaction was that it should also be built so that any MD build
problems that could show up would be shaken out.

> I.e, I think this change should be backed out.
> (Or all of rev 1.431 removed)

Feel free to revert my change if that's deemed to be the right thing
to do, I'll be mostly-offline the next few days.

Regards,

- Håvard