Re: CVS commit: src/sys/arch/amiga/include

[Chuck Silvers <chuq%chuq.com@localhost>]

On Mon, Jan 31, 2005 at 10:00:12PM +0100, Klaus Klein wrote:
> On Fri, Jan 28, 2005 at 10:19:57AM +0000, Ignatios Souvatzis wrote:
> > 
> > Module Name:        src
> > Committed By:       is
> > Date:               Fri Jan 28 10:19:57 UTC 2005
> > 
> > Modified Files:
> >     src/sys/arch/amiga/include: param.h
> > 
> > Log Message:
> > Don't expose spl functions to non-kernel.
> 
> Wouldn't it be much more opportune to implement a proper <machine/intr.h>
> and get rid of those definitions in param.h (or their inclusion from it)
> entirely?

my moving the amiga spl* stuff to machine/intr.h was what caused
this problem.  :-)

the convention seems to be that including sys/param.h in the kernel context
gets you the spl* definitions, all of the machine/param.h files do it one
way or another.  I tried leaving it out but various of the netinet stuff
doesn't work without it.  amiga is just going with the flow.

if you want to try to unwind the nested (and occasionally recursive) includes,
go right ahead.  but on some platforms at least, it's quite a mess.

-Chuck