On Thu, Feb 10, 2005 at 10:22:32PM +0000, David Laight wrote: > > Module Name: src > Committed By: dsl > Date: Thu Feb 10 22:22:32 UTC 2005 > > Added Files: > src/sys/ufs/ffs: ffs_snapshot_stub.c > > Log Message: > Add a stub file so that snapshot support can be compiled out. > Will allow INSTALL_TINY to fit back in its designated space. This part sounds good. > Since the calling code doesn't allow a snapshot mount to fail, this code > will output a warning and delete any snapshots it finds. > This only happend on rw mounts - snapshots don't seem to be created > when mounting ro. This point seems very wrong. If I understand you, with your INSTALL_TINY hack, if someone tries to mount a snapshot, all snapshots on the disk will be destroyed. That strikes me as VERY dangerous, assuming I understand the issues right. If I'm misunderstanding, please let me know. :-) > The whole way the snapshots gets mounted is a PITA anyway, the superblock > 'last mounted' time should be used to validate that the fs hasn't been > mounted elsewhere. Sounds reasonable. Take care, Bill
Attachment:
pgpDnEbQ2K2r3.pgp
Description: PGP signature