Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/gnu/dist/gettext/gettext-tools/src



In article <20050501214215.GQ15196%dmath5.geometrie.tuwien.ac.at@localhost>
wiz%NetBSD.org@localhost wrote:

> On Mon, May 02, 2005 at 01:52:52AM +0900, Izumi Tsutsui wrote:
> > Isn't it better to test ((mbc->buf[0] & 0x80) == 0) for readability
> > if it checks control characters?
> 
> In this case it doesn't, the line was:
>       mbc->buf[0] >= 0x00 && mbc->buf[0] <= 0x1F

I meant
        ((mbc->buf[0] & 0x80) == 0 && mbc->buf[0] <= 0x1F)
but maybe we should punt it to gettext maintainers...
---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index