Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/sys



> On May 30,  6:30am, yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> -- Subject: Re: CVS commit: src/sys/sys
> 
> | > Modified Files:
> | >   src/sys/sys: proc.h
> | > 
> | > Log Message:
> | > make ltsleep and wakeup* vars volatile.
> | 
> | why?
> 
> Because many of the variables they are passed in are already volatile,
> and there is no way that I know to convert a non-volatile variable to
> a volatile. I've been going through the kernel and fixing the volatile
> cast-aways, and it seems to me that there is a lot of random volatile
> and __volatile use for no good reason. We definitely need to go through
> it and clean it up. In this pass, I am making the kernel compile with
> -Wcast-qual so we will be able in the future to control better the
> volatile casting and propagation.
> 
> christos

in the case of sleep ident, how about:

void    __wakeup(uintptr_t);
#define wakeup(v)       __wakeup((uintptr_t)(v))

YAMAMOTO Takashi



Home | Main Index | Thread Index | Old Index