Source-Changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/arch
On May 30, 10:34pm, thorpej%shagadelic.org@localhost (Jason Thorpe) wrote:
-- Subject: Re: CVS commit: src/sys/arch
|
| On May 30, 2005, at 9:35 PM, Christos Zoulas wrote:
|
| > On May 30, 9:24pm, thorpej%shagadelic.org@localhost (Jason Thorpe) wrote:
| > -- Subject: Re: CVS commit: src/sys/arch
| >
| > | You don't need GENASSYM as a program name -- the variable that holds
| > | it is called TOOL_GENASSYM.
| > |
| > | I suggest you back these changes out.
| >
| > You are creating new conventions. Look at the Makefile.kern.inc first.
|
| New conventions? TOOL_* was a convention that already exists in our
| source tree.
|
| And if you're talking about this:
|
| UUDECODE?= ${TOOL_UUDECODE:Uuudecode}
| HEXDUMP?= ${TOOL_HEXDUMP:Uhexdump}
| GENASSYM?= ${TOOL_GENASSYM:Ugenassym}
|
| Those are some funny new conventions all in their own. The right
| place for those to be picked up is from bsd.own.mk, with all of the
| other tools.
No, I am talking about ${MAKE}, ${CC}, ${CPP}, ${ELF2ECOFF}, ${MKDEP},
${OBJCOPY}, ${OBJDUMP}, ${STRIP}, ${AWK}, ... I.e. all programs that
are used by the build infrastructure and exist both as tools an in
the tree.
As for the three mentioned above, I am not sure why those are in
Makefile.kern.inc, I just followed suit. Yes, those should probably
be fixed.
christos
Home |
Main Index |
Thread Index |
Old Index