m_copydata() vs. const (was: CVS commit: src/sys)

[Matthias Scheler <tron%zhadum.de@localhost>]

> > Module Name:        src
> > Committed By:       martin
> > Date:               Mon Jun  6 04:50:28 UTC 2005
> > 
> > Modified Files:
> >     src/sys/kern: uipc_mbuf.c
> >     src/sys/sys: mbuf.h
> > 
> > Log Message:
> > Constify the source arg of m_copydata
> 
> Uhh - sorry, just noticed we had been there already.

Yes, please back this change out.

> But un-consting it now needs quite a few changes all over the place the
> probably should be commited together with the change.

I don't think so.

> Matthias, how did you get if_stf* to compile without the const mbuf arg?

Via this change:

Module Name:    src
Committed By:   tron
Date:           Thu Jun  2 15:21:35 UTC 2005

Modified Files:
        src/sys/net: if_stf.c
        src/sys/netinet: in_gif.c ip_encap.c ip_encap.h
        src/sys/netinet6: in6_gif.c in6_gif.h

Log Message:
Change the first argument of the encapsulation check function from
"const struct mbuf *" to "struct mbuf *". Without this change the
actual implementation cannot even use m_copydata() on the mbuf chain
which is broken.

To generate a diff of this commit:
cvs rdiff -r1.47 -r1.48 src/sys/net/if_stf.c
cvs rdiff -r1.43 -r1.44 src/sys/netinet/in_gif.c
cvs rdiff -r1.23 -r1.24 src/sys/netinet/ip_encap.c
cvs rdiff -r1.6 -r1.7 src/sys/netinet/ip_encap.h
cvs rdiff -r1.41 -r1.42 src/sys/netinet6/in6_gif.c
cvs rdiff -r1.9 -r1.10 src/sys/netinet6/in6_gif.h

Are your sources out of date perhaps?

        Kind regards

-- 
Matthias Scheler                                  http://scheler.de/~matthias/