Re: CVS commit: src/sys/dist/pf/net

[Simon Burge <simonb%wasabisystems.com@localhost>]

James Chacon wrote:

> On Tue, Jun 14, 2005 at 11:40:59AM +1000, Luke Mewburn wrote:
> > On Mon, Jun 13, 2005 at 08:33:54PM +0000, James Chacon wrote:
> >   | 
> >   | Module Name:    src
> >   | Committed By:   jmc
> >   | Date:           Mon Jun 13 20:33:54 UTC 2005
> >   | 
> >   | Modified Files:
> >   |         src/sys/dist/pf/net: pf.c
> >   | 
> >   | Log Message:
> >   | Fix unitialized warnings that only crop up on m68k. XXGCC taggedd
> > 
> > For consistency with other occurrences of XXXGCC in the source,
> > could you move these to to separate initializations (after the
> > variable declaration block) and make the comment text more
> > consistent (e.g., "XXXGCC -Wuninitialized m68k")?
> 
> Will do. Are we marking all -Wuninitialized with XXXGCC or only ones that
> showed up on specific archs only?

Any -Wuninitialized warning that is incorrect should be marked with
XXXGCC.  In the past, just /* XXXGCC */ was used, but
/* XXXGCC -Wuninitialized */ seems to be more common now.

Simon.
--
Simon Burge                            <simonb%wasabisystems.com@localhost>
NetBSD Support and Service:         http://www.wasabisystems.com/