Re: CVS commit: src/sys/nfs

[christos%astron.com@localhost (Christos Zoulas)]

In article <1120918220.880774.7971.nullmailer%yamt.dyndns.org@localhost>,
YAMAMOTO Takashi  <yamt%mwd.biglobe.ne.jp@localhost> wrote:
>
>prior to ubc, struct buf used to hold credentials.
>so chuq might have some opinions.
>
>maybe it isn't very important which credential is used here
>because the result is cached and shared between users anyway.

Well, this is as good as using curproc anyway.

>> It would be nice to have the notion of "who are we doing the i/o on behalf
>> of" in uio, but we don't, and yes I agree uio_procp->p_ucred is not it
>> (since in the UIO_SYSSPACE case uio_procp is NULL).
>
>i'm not sure if it belongs to uio.

Yes, but it has to either be kept in a struct or passed through with the
request. And passing it through will not help with deferred requests.

>how about letting nfs_readlink() hold a credential in n_rcred as
>nfs_open() does, so that it can be used by nfs_doio_read() later?

That sounds fine. For reference, FreeBSD passes thread info and
credentials through to nfs_doio().

christos