Re: CVS commit: [netbsd-2] src/usr.bin/grep

[Jukka Salmi <j+nbsd%2005.salmi.ch@localhost>]

Jeff Rizzo --> source-changes (2005-07-15 16:56:19 -0700):
> I don't see the build breakage you indicate (at least not on i386 - are
> you building on a different platform?), and it does look like the change
> requested in ticket 2044.  (revision 1.3 of src/usr.bin/grep/binary.c).
> In fact, the patch you sent below reverts part of the change in that
> revision which was applied by mlelstv's patch.   Am I missing something?

I'm building on i386, too. Reading the [1]ticket, the patch for binary.c
attached to the message sent to you by Michael and resent to pullup-2 by
you (Message-Id: <20050705222559.GA4805%serpens.de@localhost>) , this is not 
what
you commited.

The build fails as follows:

$ cd src/usr.bin/grep
$ $TOOLDIR/bin/nbmake-$(uname -m) obj dependall
[...]
#   compile  grep/binary.o
/opt/tools/i386/bin/i386--netbsdelf-gcc -O2  -Wall -Wstrict-prototypes 
-Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional 
-Wno-uninitialized -Wreturn-type -Wswitch -Wshadow  -Werror    -nostdinc 
-isystem /opt/dst/i386/usr/include  -c    /usr/src/usr.bin/grep/binary.c
/usr/src/usr.bin/grep/binary.c: In function `gzbin_file':
/usr/src/usr.bin/grep/binary.c:77: warning: implicit declaration of function 
`okchar'

But maybe I am missing something...


Cheers, Jukka

[1] http://releng.netbsd.org/cgi-bin/req-2-0.cgi?show=2044

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~