Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/amd/libamu



>>> matthew green <mrg%eterna.com.au@localhost> wrote

>    > Module Name:     src
>    > Committed By:    nakayama
>    > Date:            Tue Aug  9 21:49:23 UTC 2005
>    > 
>    > Modified Files:
>    >  src/usr.sbin/amd/libamu: mkconf
>    > 
>    > Log Message:
>    > Embed machine and cpu architecture correctly by target host environmet,
>    > not by build host.
>    > 
>    > Pointed out by Davide Zanon and Rui Paulo in current-users@.
>    
>    In general, we should use uname(3) rather than ${MACHINE} string
>    constants because it prevents sharing binaries among machines
>    which have the same ${MACHINE_ARCH}.
> 
> 
> i haven't looked at this code, but, for cross builds doesn't this
> need to use $MACHINE_ARCH not uname(3)?

Yes it doesn't. Tsutsui-san pointed out an advanced usage.

Amd(8) have ${arch} and ${karch} selectors. ${arch} is fetched from
the compile-time HOST_ARCH string (it's now ${MACHINE} string). And
${karch} is fetched from uname(3).

For such purpose, using ${karch} selector soleved the problem.
Or should we also set ${karch} from uname(3)?

-- Takeshi Nakayama



Home | Main Index | Thread Index | Old Index