Re: CVS commit: src/gnu/usr.sbin/postfix/tlsmgr

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

On Sun, Sep 04, 2005 at 08:54:15PM +0200, Havard Eidnes wrote:
> > > LIBCRYPTO is also needed, fixes build on sun2 (static link only, so far).
> >
> > Could you please tell me where LIBCRYPTO gets defined?
> > I can't find it in src/share/mk 
> 
> LIBCRYPTO gets defined in a loop in bsd.prog.mk:

Ah, where it gets defined.

[..]
> > IMHO it needs to be added to bsd.hostprog.mk
> 
> Hm, is postfix's tlsmgr a host program?

No, forget that part.

> Though...  It seems to me that the order of the libraries on that link
> line is "off" -- I would expect -lcrypto to be needed after -lssl.
> For dynamic-linking systems the ordering doesn't matter, but not so
> for static-linking systems, of which we still have at least one.  Yes,
> I realize that referring explicitly to the *.a fila (via LIBCRYPTO)
> was not a great move, and that -l<lib> might be preferable for
> referring to common system libraries.

It did matter for me, but I don't know why, because it works now without
changing it.

> > -LDADD+= ${LIBPMASTER} ${LIBPGLOBAL} ${LIBPTLS} ${LIBCRYPTO} ${LIBPUTIL} 
> > -lssl
> > +LDADD+= ${LIBPMASTER} ${LIBPGLOBAL} ${LIBPTLS} -lcrypto ${LIBPUTIL} -lssl
> 
> let me suggest
> 
> -DPADD+= ${LIBPMASTER} ${LIBPGLOBAL} ${LIBPTLS} ${LIBCRYPTO} ${LIBPUTIL}
> +DPADD+= ${LIBPMASTER} ${LIBPGLOBAL} ${LIBPTLS} ${LIBPUTIL} ${LIBCRYPTO}
> -LDADD+= ${LIBPMASTER} ${LIBPGLOBAL} ${LIBPTLS} ${LIBCRYPTO} ${LIBPUTIL} -lssl
> +LDADD+= ${LIBPMASTER} ${LIBPGLOBAL} ${LIBPTLS} ${LIBPUTIL} -lssl -lcrypto
> 
> With this in place, it links both for i386 and sun2.

Hmm, what is now needed, libcrypto, libssl or both?

Bernd