Re: CVS commit: src/sys/fs/tmpfs

["Julio M. Merino Vidal" <jmmv84%gmail.com@localhost>]

On 9/12/05, YAMAMOTO Takashi <yamt%netbsd.org@localhost> wrote:
> 
> Module Name:    src
> Committed By:   yamt
> Date:           Mon Sep 12 19:56:58 UTC 2005
> 
> Modified Files:
>         src/sys/fs/tmpfs: tmpfs_pool.c tmpfs_pool.h
> 
> Log Message:
> - don't keep a reference to a variable on stack.

Thanks for fixing this issue.

Please add a little description of the new tp_name field into tmpfs.9.

> - remove a meaningless assumption about the order of structure members.

This is not enough.  There are other places that assume this too, such as
the TMPFS_POOL_{GET,PUT} macros.  (The initial idea was to be able to treat
a tmpfs_pool object just like a regular pool, thus assuming that the internal
pool was the first field and that pointers could be "downgraded" to
"pool *" without problems.  But I guess this is not a good idea, or, in fact,
needed anywhere.)



-- 
Julio M. Merino Vidal <jmmv84%gmail.com@localhost>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/