Re: CVS commit: src/sys/dev/usb

["Nathan J. Williams" <nathanw%wasabisystems.com@localhost>]

"Perry E. Metzger" <perry%piermont.com@localhost> writes:

> "Nathan J. Williams" <nathanw%wasabisystems.com@localhost> writes:
> > "Perry E. Metzger" <perry%piermont.com@localhost> writes:
> >
> >> Have you tried this on the known buggy and very common SanDisk
> >> disk-on-key systems?
> >
> > Nope, I don't have one of that brand. If you've got one and this
> > breaks it, please file a PR.
> >
> > Is it known to be buggy in exactly this respect?
> 
> I believe it is indeed. It was broken until not that long ago. I'll go
> and check the new code against the old and let you know what happens.

The code that I changed has been in place for about six years, so
whatever it was that fixed it, it was something else. Can you point me
at any of the reports of failure?

> I'm reluctant to simply file a PR -- I'd prefer that we actually work
> this out now if it turns out to be an issue, since Sandisk is such a
> common brand.

Well, if you find that it fails, let me know. I don't see any reason
why a PR isn't sufficient for that purpose.

        - Nathan