Re: CVS commit: src/usr.bin/login

[jnemeth%victoria.tc.ca@localhost (John Nemeth)]

On Feb 11,  4:43am, Jason Thorpe wrote:
} On Sep 21, 2005, at 9:48 AM, Christos Zoulas wrote:
} > On Sep 21,  9:19am, thorpej%shagadelic.org@localhost (Jason Thorpe) wrote:
} >
} > | > Modified Files:
} > | >         src/usr.bin/login: login_pam.c
} > | >
} > | > Log Message:
} > | > use getgrnam_r; from Jon Nemeth
} > |
} > | Just curious -- what is the point / benefit of using _r in single-
} > | threaded apps?  Sure, in libraries it makes perfect sense... but in
} > | login(1)?
} >
} > Consistency?
} 
} IMO, it's gratuitous change.

     All applications that use PAM were converted.  This is in case a
PAM module uses get{gr,pw}* functions without using the _r functions.
I noticed that FreeBSD did this with rexecd for this reason.  I posted
about it on our mailling lists.  I don't recall who in the NetBSD camp
decided to do the same thing and started converting apps.  It wasn't
me, I just finished it.

     Note that all PAM modules supplied with NetBSD have been converted
to using the _r functions so that they don't affect applications using
them.  However, the PAM using applications were still converted to
using _r functions, just in case a third party PAM module isn't as
cautious.

}-- End of excerpt from Jason Thorpe