Re: CVS commit: src/sys/dev/ic

[Greg Troxel <gdt%ir.bbn.com@localhost>]

David Young <dyoung%pobox.com@localhost> writes:

> On Fri, Oct 14, 2005 at 12:26:45AM +0000, Greg Troxel wrote:
>
> > When bringing an interface up, and thus perhaps having just powered it
> > on (e.g. cardbus), write the wep keys to the card.  Fixes problem of
> > receiving gibberish if one has set wep keys before bringing the
> > interface up, and also after ifconfig ath0 down; ifconfig ath0 up.
> 
> Thanks!

If you could confirm this works with current current, I'd appreciate
it.

> > (Tested with current from 20050926 with local mods, and discussed with
> > sam@ and dyoung@.  This is not 100% right, but significantly better
> > than before.  Really we should have an interator in net80211 to repush
> > all key state, include per-node keys.)
> 
> ISTR Sam explained that is not necessary, since there can be no per-node
> keys to restore on the INIT->* transition.

OK, but it would be nice to push the semantic knowledge of what needs
setting (assuming all card state lost) to net80211, since this "no
nodes on INIT->*" invariant lives in that code.

I haven't tried suspend/resume with wep keys, partly because I tend to
resume in different places, partly because I take the card out so it
won't get broken, and partly because the machine locks up with X :-(

-- 
        Greg Troxel <gdt%ir.bbn.com@localhost>