Subject: Re: CVS commit: src/sys/dev/pci
To: None <tls@NetBSD.org>
From: Sam Leffler <sam@errno.com>
List: source-changes
Date: 10/15/2005 10:44:43
Thor Lancelot Simon wrote:
> Module Name: src
> Committed By: tls
> Date: Sat Oct 15 04:31:20 UTC 2005
>
> Modified Files:
> src/sys/dev/pci: hifn7751.c
>
> Log Message:
> From OpenBSD hifn7751.c revision 1.149: enable the command-wait interrupt
> even if there's only one request in the queue. Sometimes we seem to miss
> multiple interrupts, and command-wait saves us.
FWIW I believe this is just covering up a race elsewhere in the driver
and the WAR has non-trivial cost. The problem appears to occur only when
the irq is shared. If you see it w/o a shared irq I'd be interested in
hearing about it.
Sam