Re: CVS commit: src/sys

[Juan RP <juan%xtrarom.org@localhost>]

On Sat, 15 Oct 2005 17:29:32 +0000 (UTC)
YAMAMOTO Takashi <yamt%netbsd.org@localhost> wrote:

> 
> Module Name:  src
> Committed By: yamt
> Date:         Sat Oct 15 17:29:32 UTC 2005
        src/sys/sys: bufq_impl.h
> 
> Log Message:
> - change the way to specify a bufq strategy.  (by string rather than
> by number)
> - rather than embedding bufq_state in driver softc,
>   have a pointer to the former.
> - move bufq related functions from kern/subr_disk.c to
> kern/subr_bufq.c.
> - rename method to strategy for consistency.
> - move some definitions which don't need to be exposed to the rest of
> kernel from sys/bufq.h to sys/bufq_impl.h.
>   (is it better to move it to kern/ or somewhere?)
> - fix some obvious breakage in dev/qbus/ts.c.  (not tested)

Thanks for doing this. Now BUFQ_READPRIO fails:

 #   compile  Nocturno/bufq_readprio.o
/home/juan/build/tools/bin/i386--netbsdelf-gcc -ffreestanding -O2
-Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith
-Wmissing-prototypes -Wstrict-prototypes -Wreturn-type -Wswitch
-Wshadow -Wcast-qual -Wwrite-strings -Wno-sign-compare
-fno-zero-initialized-in-bss -Di386 -I. -I/usr/src/sys/arch
-I/usr/src/sys -nostdinc -DGPROF -DMAXUSERS=32 -D_KERNEL -D_KERNEL_OPT
-pg
-c /usr/src/sys/kern/bufq_readprio.c /usr/src/sys/kern/bufq_readprio.c:111:
error: parse error before numeric
constant /usr/src/sys/kern/bufq_readprio.c:111: warning: type defaults
to `int' in declaration of
`BUFQ_DEFINE' /usr/src/sys/kern/bufq_readprio.c:111: warning: function
declaration isn't a prototype /usr/src/sys/kern/bufq_readprio.c:111:
warning: data definition has no type or storage
class /usr/src/sys/kern/bufq_readprio.c: In function
`bufq_prio_put': /usr/src/sys/kern/bufq_readprio.c:116: error:
dereferencing pointer to incomplete
type /usr/src/sys/kern/bufq_readprio.c:120: error: dereferencing
pointer to incomplete type /usr/src/sys/kern/bufq_readprio.c:144:
warning: implicit declaration of function
`buf_inorder' /usr/src/sys/kern/bufq_readprio.c: In function
`bufq_prio_get': /usr/src/sys/kern/bufq_readprio.c:163: error:
dereferencing pointer to incomplete
type /usr/src/sys/kern/bufq_readprio.c: In function
`bufq_readprio_init': /usr/src/sys/kern/bufq_readprio.c:226: error:
dereferencing pointer to incomplete
type /usr/src/sys/kern/bufq_readprio.c:227: error: dereferencing
pointer to incomplete type /usr/src/sys/kern/bufq_readprio.c:228:
error: dereferencing pointer to incomplete
type /usr/src/sys/kern/bufq_readprio.c:230: error: dereferencing
pointer to incomplete type /usr/src/sys/kern/bufq_readprio.c: At top
level: /usr/src/sys/kern/bufq_readprio.c:223: warning:
`bufq_readprio_init' defined but not used