Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch



In article <20051105140754.0D10523572%thoreau.thistledown.com.au@localhost>
simonb%wasabisystems.com@localhost wrote:

> I'm also not 100% sure if we should
> provide defaults for MIPS3_NWIRED_ENTRY

I wondered it, but it's upper limit so I thought it was okay.

> (should that be called
> MIPS3_NWIRED_ENTRIES?)

Yeah, I just follow VM_NFREELIST but maybe my English is vague ;-)

> and MIPS3_WIRED_SIZE in <mips/wired_map.h>
> or whether we specify that these constants have to be defined
> in <machine/wired_map.h>.

IMHO it's also okay because 16Mbytes page is reasonable for wired map.
(thought current code won't work on MIPS_R4100)

> I think it's cleaner to only have them if they're used, similar to say
> <machine/pci_machdep.h> which only exists for some MIPS ports.

Well, pci stuff is defined in MD conf/files.*, isn't it? ;-)

> I'll
> remove them (but not tonight - too late already!).

No problem, thanks.
---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index