Re: CVS commit: src/sys/dev/ic

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

In article <20051128210320.41BD22DA27%cvs.netbsd.org@localhost>
bouyer%NetBSD.org@localhost wrote:

> Module Name:  src
> Committed By: bouyer
> Date:         Mon Nov 28 21:03:20 UTC 2005
> 
> Modified Files:
>       src/sys/dev/ic: aic79xx.c aic79xx_osm.c aic79xxvar.h aic7xxx.c
>           aic7xxx_inline.h aic7xxx_osm.c aic7xxxvar.h
> 
> Log Message:
> Don't call alloc_scb() (which can call bus_dmamem_alloc/map) from
> ADAPTER_REQ_RUN_XFER context (which can be interrupt context), defer this
> to the ADAPTER_REQ_GROW_RESOURCES callback.

Is this printf needed except for debug?
---
Izumi Tsutsui


Index: aic7xxx_osm.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/aic7xxx_osm.c,v
retrieving revision 1.19
diff -u -r1.19 aic7xxx_osm.c
--- aic7xxx_osm.c       28 Nov 2005 21:03:20 -0000      1.19
+++ aic7xxx_osm.c       4 Dec 2005 08:19:23 -0000
@@ -329,7 +329,9 @@
                break;
          }
        case ADAPTER_REQ_GROW_RESOURCES:
+#ifdef AHC_DEBUG
                printf("%s: ADAPTER_REQ_GROW_RESOURCES\n", ahc_name(ahc));
+#endif
                chan->chan_adapter->adapt_openings += ahc_alloc_scbs(ahc);
                if (ahc->scb_data->numscbs >= AHC_SCB_MAX_ALLOC)
                        chan->chan_flags &= ~SCSIPI_CHAN_CANGROW;

---
Izumi Tsutsui