On Wed, Dec 14, 2005 at 09:42:52PM +0000, David Laight wrote: > > > > If the rval is SCAN_CONTINUE it now returns a standard error that no > > > > disklabel was found instead of the NULL. > > > > > > Hummm - that was more or less deliberate, IIRC some of the callers > > > need a disklabel filled in with partition 'a' and 'd' when there > > > is nothing found on the disk. Deliberate??? you leave an obvious bug there deliberately? > I've reverted it, it breaks the default label for disks that have neither > MBR nor NetBSD label. > There may be alternative fixes to retain more of the default label... Sounds like those places need fixing! The `default label' IS still passed back only the resulting string changed. Without the change its impossible to tell by the caller that a disklabel is present or not and thus is impossible to select the default label. Reinoud
Attachment:
pgpDZMZzFj2l_.pgp
Description: PGP signature