Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/net



matthew green <mrg%eterna.com.au@localhost> writes:
>    Module Name:       src
>    Committed By:      perry
>    Date:              Wed Jan  4 21:10:09 UTC 2006
>    
>    Modified Files:
>       src/sys/net: pfil.h
>    
>    Log Message:
>    #ifdef _KERNEL some function prototypes and an inline function
>    definition.
>    
>    XXX It may be that this file needs more namespace cleaning (or the
>    files that include it, like if.h, might need it.)
>
> huh.  is this file actually used by userland?  i'd not expect so and
> i guess it should never have been installed.  i don't see how it's
> useful for userland in any way...

I agree, but net/if.h includes it for some non-obvious reason.

I also agree that the #ifdef is probably not optimal -- possibly this
should be done differently, such as by #ifdef'ing in if.h -- but after
a couple of days I had to allow pkgsrc/x11/xorg to build again. We can
change it around though if we have a definitive solution.

Perry



Home | Main Index | Thread Index | Old Index