Re: CVS commit: src/sys/arch/evbmips

["Garrett D'Amore" <garrett_damore%tadpole.com@localhost>]

Izumi Tsutsui wrote:
> In article <20060223171401.27E742DA27%cvs.netbsd.org@localhost>
> shige%NetBSD.org@localhost wrote:
>
>   
>> Module Name: src
>> Committed By:        shige
>> Date:                Thu Feb 23 17:14:01 UTC 2006
>>
>> Modified Files:
>>      src/sys/arch/evbmips/conf: files.alchemy
>> Added Files:
>>      src/sys/arch/evbmips/alchemy: omsal400.c omsal400reg.h
>>      src/sys/arch/evbmips/conf: OMSAL400
>>
>> Log Message:
>> Support Plathome OpenMicroServer (OMS-AL400).
>> http://www.plathome.co.jp/products/oms400/index.html (sorry japanese only).
>>     
>
> Isn't it better to create new directory for the machine
> (evbmips/oms400 etc)? I guess evbmips/alchemy is a directory
> for the AMD's Development Boards for Au1xxx CPUs.
>   
I don't think this has to be so fixed in stone.  The alchemy machdep.c
is pretty universal for any boards based on the Alchemy processor with
YAMON, and I think that as long as it works, it doesn't make sense to go
around populating additional trees.

In particular, it might require reinventing infrastructure that we
already have in place to deal with e.g different PCI routing, PCMCIA
support, etc.

Btw, I added a MTX-1 config in the same location, so shige@ is probably
just following my lead, for better or worse. :-)

> Anyway, please have a review before commit as noted in
> the commit guidelines. Thanks.
>   
Agreed. :-)
> ---
> Izumi Tsutsui
>   

    -- Garrett

-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191