Re: CVS commit: src/sys/nfs

[David Laight <david%l8s.co.uk@localhost>]

On Wed, Mar 01, 2006 at 06:36:20PM +0000, Christos Zoulas wrote:
> >
>                       slp->ns_reclen = recmark & ~0x80000000;
>                       [...]
>                         if (slp->ns_reclen > NFS_MAXPACKET
>                             || slp->ns_reclen <= 0) {
>  
> How can slp->ns_reclen be negative? I think that you only care about the
> 0 case, right?

What if recmark is a 64bit quantity?
Maybe that ought to be &0x7fffffff.
In any case the compiler might generate better code for the <= case.

        David

-- 
David Laight: david%l8s.co.uk@localhost