Re: CVS commit: src/sys/arch/mips/alchemy/dev

[Simon Burge <simonb%wasabisystems.com@localhost>]

Shigeyuki Fukushima wrote:

> Simon Burge wrote:
> > Shigeyuki Fukushima wrote:
> > 
> >> Module Name:       src
> >> Committed By:      shige
> >> Date:              Mon Mar  6 17:12:24 UTC 2006
> >>
> >> Added Files:
> >>
> >>    src/sys/arch/mips/alchemy/dev: smbusreg.h
> >>
> >> Log Message:
> >>
> >> Add register definitions for AuXXXX SMBus protocol.
> > 
> > I wonder if this header name shouldn't have "psc" somewhere in the
> > filename?  These are register definitions that are specific to the
> > PSC version of the SMBus controller right?
> 
> I don't know whether PSC specific or not.
> PSC device on alchemy supports four protocols: AC97, I2S, SPI, SMBus.
> I'm following to sys/arch/mips/alchemy/dev/ac97reg.h naming.

That ac97reg.h predates the existance of the Au1550 PSC.  I haven't
looked at the differences between the old (Au1{0,1,5}00) AC97 and new
PSC AC97 to be able to tell if they can share code or not yet.

For SMBus there is no previous driver in the Alchemy parts (although
some Alchemy based boards just used GPIO pins for this), so I think it
might be better to call this psc_smbusreg.h or pscsmbusreg.h or similar.

Simon.
--
Simon Burge                            <simonb%wasabisystems.com@localhost>
NetBSD Support and Service:         http://www.wasabisystems.com/