Re: CVS commit: [elad-kernelauth] src/sys

[Elad Efrat <elad%NetBSD.org@localhost>]

Hi,

YAMAMOTO Takashi wrote:

> - IMO, it's better to use "org.netbsd.kauth.generic" as TN says.

Cosmetics. I'll change it if it's important enough.

> - how about providing suser() as a wrapper of KAUTH_GENERIC_ISSUSER? (for 
> now?)

There are no more calls to suser() in this branch, why add them again?

> - builtin_process seems like a too generic name to me.

Explain please.

> - will you convert CURTAIN to KAUTH_PROCESS_CANSEE?

Yes.

> - locking seems broken.  try LOCKDEBUG.

Yeah... my test kernel is running with DEBUG + DIAGNOSTIC but not
LOCKDEBUG (thanks! :) -- one of the purposes of putting this code on
CVS was to get some more eyes on it than my two...

There's also an issue with set-id binaries it seems; I'm trying to
work it out in the little time I have.

> - consider to follow our style.

Will do; there's still lots of cleaning to do in these files. Some
of the code is temporary only.

> - you can use SIMPLEQ_INSERT_TAIL on an empty queue.

Okay, thanks.

-e.

-- 
Elad Efrat